Work around dask/distributed#7940 #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dask/distributed#7940 we are discussing how calling
self.asynchronousnow raises an exception if there is no loop running because it tried to access theLoopRunner.loopbefore the loop is created. We do this inKubeClusterto check whether we need to start the loop.I've opened dask/distributed#7941 to fix things but also replacing that check with a check suggested by @graingert which means we don't try and use
self.loopuntil after the loop as been created anyway.This PR means we can move forward whether dask/distributed#7941 gets accepted and we aren't waiting on a release, it should also unblock the current CI failures.