Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Autoscaler example code snippet on the docs index page #905

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Fix Autoscaler example code snippet on the docs index page #905

merged 2 commits into from
Sep 3, 2024

Conversation

marcelovilla
Copy link
Contributor

Fixes #904

jacobtomlinson
jacobtomlinson requested changes Sep 3, 2024
View reviewed changes
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this. It's not actually a duplicate, it is just a broken example.

Instead of saying cluster.scale(10) it should say cluster.adapt(minimum=1, maximum=10).

Would you mind updating the example?

@jacobtomlinson jacobtomlinson mentioned this pull request Sep 3, 2024
Closed
@marcelovilla marcelovilla changed the title Remove duplicate code snippet on the docs index page Fix Autoscaler example code snippet on the docs index page Sep 3, 2024
jacobtomlinson
jacobtomlinson approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround here!

@jacobtomlinson jacobtomlinson merged commit 2ecfdcd into dask:main Sep 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtomlinson jacobtomlinson jacobtomlinson approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect example code snippet in the Autoscalers section of the docs index page
2 participants
@marcelovilla @jacobtomlinson