Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reworked dependency injection to be better decoupled from global state and better facilitate unit testing #23

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Reworked dependency injection to be better decoupled from global state and better facilitate unit testing #23

wants to merge 6 commits into from

Conversation

rmodig
Copy link
Member

@rmodig rmodig commented Apr 9, 2021

DO NOT MERGE

Looking for some general feedback about this approach. Still needs to be tweaked and not yet fully implemented.

@rmodig rmodig requested a review from bjorhn April 9, 2021 13:58
@rmodig rmodig added enhancement New feature or request work in progress This PR isn't ready to be merged labels Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorhn bjorhn Awaiting requested review from bjorhn

Assignees
No one assigned
Labels
enhancement New feature or request work in progress This PR isn't ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmodig @bjorhn