Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: improved retrieval of cookies workflow #616

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

ahuangg
Copy link
Contributor

@ahuangg ahuangg commented Dec 6, 2024

Issue

  • previous commit only adds the cookie to the config.json when the program is ran for the first time, this will require manual intervention if anything happens to the cookie.

Solution

  • updated cookie workflow to check if the user is logged in
  • the cookie updates if the user is logged in and the new cookie is not the same as the current one
  • moved the function call to when the config is being loaded into the program

Concerns

  • takes a few seconds after logging in for retrieval to work properly
  • user now has to be logged in Weibo on Chrome for this program to run

@dataabc dataabc merged commit c34fcdc into dataabc:master Dec 7, 2024
1 check failed
@dataabc
Copy link
Owner

dataabc commented Dec 7, 2024

已merge,感谢贡献代码。

@ahuangg
Copy link
Contributor Author

ahuangg commented Dec 7, 2024

有没有什么功能,你希望我开发?

@dataabc
Copy link
Owner

dataabc commented Dec 7, 2024

太感谢了,不过暂时没有。

@ahuangg
Copy link
Contributor Author

ahuangg commented Dec 7, 2024

好的,没问题!如果以后有需要的话,随时告诉我。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants