Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGD Search is returning 0 hits in some test cases #45

Open
donaldcampbelljr opened this issue Nov 4, 2024 · 2 comments
Open

IGD Search is returning 0 hits in some test cases #45

donaldcampbelljr opened this issue Nov 4, 2024 · 2 comments
Labels
bug Something isn't working igd likely solved

Comments

@donaldcampbelljr
Copy link
Member

When using the dev branch of IGD, I notice a bug where I'm creating an .igd from a directory and my search is returning 0 hits.

However, if I create an igd from a single source file and query that source file against the igd, it appears to be working fine.

Originally posted by @donaldcampbelljr in #44 (comment)

@sanghoonio
Copy link
Member

Findings from debugging session today:

  1. some bed files result in negative avg size when making a .igd
  2. for the issue involving index out of bounds: involves gData length in get_overlaps()

Test bed files for making the igd are here: https://myuva-my.sharepoint.com/:u:/g/personal/sp5fd_virginia_edu/ESZDBr8_mjBDjl9Zr8xAkt8BJKVjoMecpdrGZE3Dqg6Bog?e=BKxNR8

@sanghoonio
Copy link
Member

Testing with small bed files shows some consistent differences between the Rust and C versions of IGD search (at least with these test files):

  1. Rust version does not capture hits at index 0
  2. Rust version does not match the number of hits in C version or GenomicRanges::countOverlaps(), and often just returns 1 hit per index

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working igd likely solved
Projects
None yet
Development

No branches or pull requests

2 participants