Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @DeveloperApi annotation #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add @DeveloperApi annotation #73

wants to merge 1 commit into from

Conversation

nfx
Copy link
Contributor

@nfx nfx commented May 5, 2023

Changes

Adds meta-information about stability of interfaces

Tests

n/a

@nfx nfx requested a review from mgyucht May 5, 2023 13:35
mgyucht
mgyucht approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Supportability-wise: should we be adding this tag to all classes we introduce into the SDK? How does that scale over time?

@nfx
Copy link
Contributor Author

nfx commented May 8, 2023

@mgyucht let's discuss this tomorrow. The only stable interface are CredentialsProvider, HeaderFactory, and the public part of DatabricksConfig. the rest should be marked with @DeveloeprApi =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht mgyucht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nfx @mgyucht