Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include node_info in SQLQueryStatus #452

Closed
colin-rogers-dbt opened this issue Sep 21, 2023 · 3 comments · Fixed by #453
Closed

Include node_info in SQLQueryStatus #452

colin-rogers-dbt opened this issue Sep 21, 2023 · 3 comments · Fixed by #453
Labels
enhancement New feature or request

Comments

@colin-rogers-dbt
Copy link
Contributor

Describe the feature

dbt-core SQLQueryStatus includes an optional node_info field. Currently dbt-databricks does not populate it when firing the event. Doing so makes it easier for consumers to utilize the logs.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

dbt-core example: https://github.com/dbt-labs/dbt-core/blob/d91265411061463b42d6f4d6d94e094a42a96d2b/core/dbt/adapters/sql/connections.py#L83

Who will this benefit?

What kind of use case will this feature be useful for? Please be specific and provide examples, this will help us prioritize properly.

Are you interested in contributing this feature?

Let us know if you want to write some code, and how we can help.

@colin-rogers-dbt colin-rogers-dbt added the enhancement New feature or request label Sep 21, 2023
@davidharting
Copy link
Contributor

@colin-rogers-dbt I am noticing that the SqlQuery events also expect to have node_info supplied and currently do not.
Would it be possible for you to apply a similar improvement to these events? The call sites are very close to the SQLQueryStatus events you already updated.

@colin-rogers-dbt
Copy link
Contributor Author

@benc-db we should reopen this issue, looks like me prior fix missed SQLQuery events

@benc-db benc-db reopened this Nov 7, 2023
@benc-db
Copy link
Collaborator

benc-db commented Nov 10, 2023

@colin-rogers-dbt I believe we can reclose now, with #494 right?

@benc-db benc-db closed this as completed Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants