-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node_info to SQLQuery events #494
Merged
benc-db
merged 2 commits into
databricks:main
from
davidharting:davidharting/add-node-info-to-sql-query-events
Nov 7, 2023
Merged
Add node_info to SQLQuery events #494
benc-db
merged 2 commits into
databricks:main
from
davidharting:davidharting/add-node-info-to-sql-query-events
Nov 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Looks like lint passed, going to move to ready for review. $ tox -e linter
|
davidharting
requested review from
andrefurlan-db,
susodapop,
benc-db and
rcypher-databricks
as code owners
October 30, 2023 21:24
rcypher-databricks
approved these changes
Nov 3, 2023
I am going on parental leave, so I am transitioning author-responsibilities for this PR over to @colin-rogers-dbt capable hands. |
benc-db
approved these changes
Nov 7, 2023
Thank you so much @benc-db! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #453, which added
node_info
to theSQLQueryStatus
event. This PR addsnode_info
to theSQLQuery
event.I did not open a separate issue for this as it feels very related to #452, but happy to log a new issue if desired!
Checklist
CHANGELOG.md
and added information about my change to the "dbt-databricks next" section.PR Status
Keeping this as draft for the moment while I get set up to run the linter and add a changelog entry.