Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate more tests to functional framework #491

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

benc-db
Copy link
Collaborator

@benc-db benc-db commented Oct 27, 2023

Description

  • Migrated two more tests (in the case of get_columns_from_relation it was through replacing with the core adapter test).
  • Deleted get_catalog test as it only appears to verify the DBR behavior and nothing about our adapter.
  • Deleted the fail-fast tests as they didn't verify anything about our adapter, and core has this covered in a non-adapter test (i.e. the behavior is the same across all adapters and doesn't need to be verified by us).

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

@benc-db benc-db merged commit 4de37c6 into main Oct 27, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants