Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Even more functional tests #512

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Even more functional tests #512

merged 3 commits into from
Nov 21, 2023

Conversation

benc-db
Copy link
Collaborator

@benc-db benc-db commented Nov 18, 2023

Description

  • Added missing ephemeral test cases
  • Added one hook test case. This required so much customization and the other cases mostly focus on different ways of specifying the hooks that I decided to leave it at one.
  • Moved a couple of files to match the organizational style

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

@benc-db benc-db merged commit bbdb10a into main Nov 21, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrefurlan-db andrefurlan-db Awaiting requested review from andrefurlan-db andrefurlan-db is a code owner

@susodapop susodapop Awaiting requested review from susodapop

@rcypher-databricks rcypher-databricks Awaiting requested review from rcypher-databricks rcypher-databricks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benc-db