Refactor reading env vars #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benc-db
requested review from
andrefurlan-db and
rcypher-databricks
as code owners
benc-db
commented
Dec 19, 2024
| @@ -475,6 +473,8 @@ def add_query( | |||
| auto_begin: bool = True, | |||
| bindings: Optional[Any] = None, | |||
| abridge_sql_log: bool = False, | |||
| retryable_exceptions: tuple[type[Exception], ...] = tuple(), | |||
There was a problem hiding this comment.
This is new interface in latest upstream. Hopefully this doesn't break anything, otherwise we (and other adapters) will be in for a world of hurt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Centralize env var reading since it is actually a global state reference, and we should be aware of as such. We will lazy set once, and return values from then on (since allowing users to change the value during a run, and have that change reflected seems crazy unpredictable).
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.