Merge pull request #186 from datacite/fix-500-errors

report on errors that occur in the rack middleware
datacite · May 22, 2024 · 1ba7f9a · 1ba7f9a
2 parents 07b92c1 + 7670578
commit 1ba7f9a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/config/environments/development.rb b/config/environments/development.rb
@@ -60,7 +60,7 @@
     use_timestamp: false,
   }
 
-  config.action_dispatch.show_exceptions = false
+  config.action_dispatch.show_exceptions = :none
 end
 
 #BetterErrors::Middleware.allow_ip! ENV['TRUSTED_IP']

diff --git a/config/environments/test.rb b/config/environments/test.rb
@@ -28,7 +28,7 @@
 
 
   # Raise exceptions instead of rendering exception templates.
-  config.action_dispatch.show_exceptions = false
+  config.action_dispatch.show_exceptions = :none
 
   # Disable request forgery protection in test environment.
   config.action_controller.allow_forgery_protection = false

diff --git a/lib/middleware/compressed_requests.rb b/lib/middleware/compressed_requests.rb
@@ -29,8 +29,13 @@ def call(env)
         env['rack.input'] = StringIO.new(extracted)
       end
 
-      status, headers, response = @app.call(env)
-      [status, headers, response]
+      begin
+        status, headers, response = @app.call(env)
+        [status, headers, response]
+      rescue => err
+        Rails.logger.error(err.inspect)
+        [500, {}, [{"status": 500, "title": err.message}.to_json]]
+      end
     end
 
     def decode(input, content_encoding)