Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to ruby 3.1.4 #176

Merged
merged 2 commits into from
Apr 12, 2024
Merged

upgrade to ruby 3.1.4 #176

merged 2 commits into from
Apr 12, 2024

Conversation

wendelfabianchinsamy
Copy link
Contributor

@wendelfabianchinsamy wendelfabianchinsamy commented Apr 11, 2024 •
edited
Loading

Purpose

closes: #175

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@wendelfabianchinsamy wendelfabianchinsamy requested a review from a team April 11, 2024 11:10
jrhoads
jrhoads reviewed Apr 11, 2024
View reviewed changes
bin/setup Outdated
@@ -15,7 +15,7 @@ chdir APP_ROOT do
# Add necessary setup steps to this file.

puts '== Installing dependencies =='
system! 'gem install bundler --conservative'
system! 'gem install bundle -v 2.5.6 r --conservative'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the r separated from the bundle?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

jrhoads
jrhoads reviewed Apr 11, 2024
View reviewed changes
Gemfile.lock Show resolved Hide resolved
@wendelfabianchinsamy wendelfabianchinsamy merged commit 6d1ec0f into master Apr 12, 2024
2 checks passed
@wendelfabianchinsamy wendelfabianchinsamy deleted the upgrade-to-ruby-3.1.4 branch April 12, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhoads jrhoads jrhoads approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Ruby 3.1.4
2 participants
@wendelfabianchinsamy @jrhoads