Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reconfigure logging #184

Merged
merged 1 commit into from
May 21, 2024
Merged

reconfigure logging #184

merged 1 commit into from
May 21, 2024

Conversation

wendelfabianchinsamy
Copy link
Contributor

Purpose

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@wendelfabianchinsamy wendelfabianchinsamy requested a review from a team May 21, 2024 12:42
ashwinisukale
ashwinisukale reviewed May 21, 2024
View reviewed changes
config/application.rb
# config.lograge.ignore_custom = lambda do |event|
# event.payload.inspect.length > 100000
# end

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this config in the latest version? is this version specific configuration?

ashwinisukale
ashwinisukale requested changes May 21, 2024
View reviewed changes
Copy link

@ashwinisukale ashwinisukale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added one comment, other wise looks good to me

@wendelfabianchinsamy
Copy link
Contributor Author

Have added one comment, other wise looks good to me

Yes. I will revert this change once I can see the error message.

@ashwinisukale ashwinisukale self-requested a review May 21, 2024 12:47
@wendelfabianchinsamy wendelfabianchinsamy merged commit 7b7f977 into master May 21, 2024
2 checks passed
@wendelfabianchinsamy wendelfabianchinsamy deleted the reimplement-logging branch May 21, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinisukale ashwinisukale ashwinisukale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wendelfabianchinsamy @ashwinisukale