Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use https status 406 instead of 500 for rack errors #187

Merged
merged 1 commit into from
May 24, 2024

Conversation

wendelfabianchinsamy
Copy link
Contributor

Purpose

closes: datacite/datacite#2136

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@wendelfabianchinsamy wendelfabianchinsamy requested a review from a team May 24, 2024 07:42
@wendelfabianchinsamy wendelfabianchinsamy merged commit a26fe85 into master May 24, 2024
2 checks passed
@wendelfabianchinsamy wendelfabianchinsamy deleted the set-gzip-errors-to-http-406 branch May 24, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage report validation errors returning 500 errors instead of 406
3 participants