fix(openalex): On deletetion, push ROR in affiliation removeList

only if it is a ror in the current affiliation
dataesr · Dec 5, 2024 · aaa66b3 · aaa66b3
1 parent e039815
commit aaa66b3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/client/src/pages/openalex-affiliations/results/index.jsx b/client/src/pages/openalex-affiliations/results/index.jsx
@@ -238,14 +238,14 @@ export default function Affiliations() {
         return {
           ...affiliation,
           addList: affiliation.addList.filter((item) => !selectedRorIds.includes(item.rorId)),
-          removeList: [...new Set([...affiliation.removeList, ...selectedRorIds])],
+          removeList: [...new Set([...affiliation.removeList, ...selectedRorIds])].filter((item) => affiliation.rors.map((_ror) => _ror.rorId).includes(item)),
           selected: false,
         };
       }
       return affiliation;
     });
     setAffiliations(affiliationsTmp);
-    setRorsToRemove([]); // TODO: Is it still used ?
+    setRorsToRemove([]);
     setIsRemoveModalOpen(false);
   };