Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): Add unit tests for consumption step no 1 #187

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

remiriv
Copy link
Collaborator

@remiriv remiriv commented Dec 14, 2022

WIP - Pour l'instant que testé étape conso 1 - reste à tester étape conso 2

Proposed changes


Rajout des tests automatisés pour les calculs des étapes de consommation après les modifications dues à l'intégration du formulaire

Types of changes


What types of changes does your code introduce to ogre ?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x ] Refactoring (no functional changes, no api changes)
  • Documentation Update (if none of the other choices apply)
  • Other (please describe): Tests

Checklist


Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

offseason_ogre/blob/master/CONTRIBUTING.md) doc

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation and modify the README.md (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • If the feature changes current behavior, reasons why your solution is better.

Copy link
Collaborator

@Baboo7 Baboo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques questions sinon c'est top 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants