Handle all MySQL Timestamp types as UTC time #174
Merged
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle all MySQL Timestamp as UTC time.
In MySQL, there's no
timestamp with time zonetype, and the retrieved value oftimestamptype depends on the timezone per session, which depends on the default server timezone where the MySQL server is located in. https://dev.mysql.com/doc/refman/8.4/en/time-zone-support.htmlTo avoid the confusion caused by the default timezone of server, which varies from machine to machine, this PR implement changes to always configure session timezone to UTC, and the timestamp value retrived from MySQL will always be in UTC time.