Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mysql BINARY, VARBINARY and Postgres Type::BYTEA #28

Merged

Conversation

Sevenannn
Copy link
Contributor

@Sevenannn Sevenannn commented Aug 2, 2024

Support mysql BINARY, VARBINARY and Postgres Type::BYTEA for the mysql table provider and postgres table provider

  • mysql BINARY & CHAR are both of type MYSQL_TYPE_STRING in mysql-async library. Add additional binary flag data to determine mysql binary / char and cast them to arrow binary / largestring accordingly

Copy link
Collaborator

@sgrebnov sgrebnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sevenannn - great catch on BINARY_FLAG 👍

@phillipleblanc phillipleblanc merged commit d7e7f22 into datafusion-contrib:main Aug 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants