-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metadata-service): Pass editableDatasetNameEnabled feature flag to the config. #11391
fix(metadata-service): Pass editableDatasetNameEnabled feature flag to the config. #11391
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@jjoyce0510, @jayasimhankv could you please review this PR, as you are more aware of the original PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding it to the config!
hey @david-leifker thanks for approving this PR, is there anything I can do to get this merged? |
Checklist
Problem statement
In #10608 there was introduced a feature-flag
editableDatasetNameEnabled
, that disables editing dataset names in the UI by default. It was proposed to pass this flag to theapplication.yaml
, that could be affected by env variable.However this flag is not present in the
application.yaml
, which makes it impossible to turn this feature on through an env variable.Let's introduce this feature flag to the
application.yaml
, so people can build the app with this feature enabled without changing the code. That would also make this feature visible to other developers.Thank you.