feat(ui): Adding incidents to ML Model + ML Feature Entities

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java

@@ -3137,7 +3137,8 @@ private void configureIncidentResolvers(final RuntimeWiring.Builder builder) {
 
     // Add incidents attribute to all entities that support it
     final List<String> entitiesWithIncidents =
-        ImmutableList.of("Dataset", "DataJob", "DataFlow", "Dashboard", "Chart");
+        ImmutableList.of(
+            "Dataset", "DataJob", "DataFlow", "Dashboard", "Chart", "MLModel", "MLFeature");
     for (String entity : entitiesWithIncidents) {
       builder.type(
           entity,

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/config/AppConfigResolver.java

@@ -277,6 +277,14 @@ private EntityType mapResourceTypeToEntityType(final String resourceType) {
         .getResourceType()
         .equals(resourceType)) {
       return EntityType.BUSINESS_ATTRIBUTE;
+    } else if (com.linkedin.metadata.authorization.PoliciesConfig.ML_MODEL_PRIVILEGES
+        .getResourceType()
+        .equals(resourceType)) {
+      return EntityType.MLMODEL;
+    } else if (com.linkedin.metadata.authorization.PoliciesConfig.ML_FEATURE_PRIVILEGES
+        .getResourceType()
+        .equals(resourceType)) {
+      return EntityType.MLFEATURE;
     } else {
       return null;
     }

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/entity/EntityPrivilegesResolver.java

@@ -12,6 +12,7 @@
 import com.linkedin.datahub.graphql.concurrency.GraphQLConcurrencyUtils;
 import com.linkedin.datahub.graphql.generated.Entity;
 import com.linkedin.datahub.graphql.generated.EntityPrivileges;
+import com.linkedin.datahub.graphql.resolvers.incident.IncidentUtils;
 import com.linkedin.datahub.graphql.resolvers.mutate.util.EmbedUtils;
 import com.linkedin.datahub.graphql.resolvers.mutate.util.GlossaryUtils;
 import com.linkedin.entity.client.EntityClient;
@@ -141,5 +142,6 @@ private void addCommonPrivileges(
       @Nonnull EntityPrivileges result, @Nonnull Urn urn, @Nonnull QueryContext context) {
     result.setCanEditLineage(canEditEntityLineage(urn, context));
     result.setCanEditProperties(AuthorizationUtils.canEditProperties(urn, context));
+    result.setCanEditIncidents(IncidentUtils.isAuthorizedToEditIncidentForResource(urn, context));
   }
 }

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/incident/IncidentUtils.java

@@ -0,0 +1,26 @@
+package com.linkedin.datahub.graphql.resolvers.incident;
+
+import com.datahub.authorization.ConjunctivePrivilegeGroup;
+import com.datahub.authorization.DisjunctivePrivilegeGroup;
+import com.google.common.collect.ImmutableList;
+import com.linkedin.common.urn.Urn;
+import com.linkedin.datahub.graphql.QueryContext;
+import com.linkedin.datahub.graphql.authorization.AuthorizationUtils;
+import com.linkedin.metadata.authorization.PoliciesConfig;
+
+public class IncidentUtils {
+  public static boolean isAuthorizedToEditIncidentForResource(
+      final Urn resourceUrn, final QueryContext context) {
+    final DisjunctivePrivilegeGroup orPrivilegeGroups =
+        new DisjunctivePrivilegeGroup(
+            ImmutableList.of(
+                AuthorizationUtils.ALL_PRIVILEGES_GROUP,
+                new ConjunctivePrivilegeGroup(
+                    ImmutableList.of(PoliciesConfig.EDIT_ENTITY_INCIDENTS_PRIVILEGE.getType()))));
+
+    return AuthorizationUtils.isAuthorized(
+        context, resourceUrn.getEntityType(), resourceUrn.toString(), orPrivilegeGroups);
+  }
+
+  private IncidentUtils() {}
+}

datahub-graphql-core/src/main/resources/auth.graphql

@@ -286,6 +286,11 @@ type EntityPrivileges {
   Whether or not a user can update the properties for the entity (e.g. dataset)
   """
   canEditProperties: Boolean
+
+  """
+  Whether or not a user can update incidents for the entity
+  """
+  canEditIncidents: Boolean
 }
 
 """

datahub-graphql-core/src/main/resources/incident.graphql

@@ -377,4 +377,42 @@ extend type Chart {
     Optional start offset, defaults to 20.
     """
     count: Int): EntityIncidentsResult
+}
+
+extend type MLModel {
+  """
+  Incidents associated with the ML Model
+  """
+  incidents(
+    """
+    Optional incident state to filter by, defaults to any state.
+    """
+    state: IncidentState,
+    """
+    Optional start offset, defaults to 0.
+    """
+    start: Int,
+    """
+    Optional start offset, defaults to 20.
+    """
+    count: Int): EntityIncidentsResult
+}
+
+extend type MLFeature {
+  """
+  Incidents associated with the ML Feature
+  """
+  incidents(
+    """
+    Optional incident state to filter by, defaults to any state.
+    """
+    state: IncidentState,
+    """
+    Optional start offset, defaults to 0.
+    """
+    start: Int,
+    """
+    Optional start offset, defaults to 20.
+    """
+    count: Int): EntityIncidentsResult
 }

datahub-web-react/src/app/entity/mlFeature/MLFeatureEntity.tsx

@@ -18,6 +18,7 @@ import { EntityMenuItems } from '../shared/EntityDropdown/EntityDropdown';
 import DataProductSection from '../shared/containers/profile/sidebar/DataProduct/DataProductSection';
 import { getDataProduct } from '../shared/utils';
 import { PropertiesTab } from '../shared/tabs/Properties/PropertiesTab';
+import { IncidentTab } from '../shared/tabs/Incident/IncidentTab';
 import SidebarStructuredPropsSection from '../shared/containers/profile/sidebar/StructuredProperties/SidebarStructuredPropsSection';
 
 /**
@@ -95,6 +96,14 @@ export class MLFeatureEntity implements Entity<MlFeature> {
                     name: 'Properties',
                     component: PropertiesTab,
                 },
+                {
+                    name: 'Incidents',
+                    component: IncidentTab,
+                    getDynamicName: (_, mlFeature) => {
+                        const activeIncidentCount = mlFeature?.mlFeature?.activeIncidents.total;
+                        return `Incidents${(activeIncidentCount && ` (${activeIncidentCount})`) || ''}`;
+                    },
+                },
             ]}
             sidebarSections={this.getSidebarSections()}
         />

datahub-web-react/src/app/entity/mlModel/MLModelEntity.tsx

@@ -18,6 +18,7 @@ import { DocumentationTab } from '../shared/tabs/Documentation/DocumentationTab'
 import MlModelFeaturesTab from './profile/MlModelFeaturesTab';
 import { EntityMenuItems } from '../shared/EntityDropdown/EntityDropdown';
 import DataProductSection from '../shared/containers/profile/sidebar/DataProduct/DataProductSection';
+import { IncidentTab } from '../shared/tabs/Incident/IncidentTab';
 import SidebarStructuredPropsSection from '../shared/containers/profile/sidebar/StructuredProperties/SidebarStructuredPropsSection';
 
 /**
@@ -126,6 +127,14 @@ export class MLModelEntity implements Entity<MlModel> {
                     name: 'Properties',
                     component: PropertiesTab,
                 },
+                {
+                    name: 'Incidents',
+                    component: IncidentTab,
+                    getDynamicName: (_, mlModel) => {
+                        const activeIncidentCount = mlModel?.mlModel?.activeIncidents.total;
+                        return `Incidents${(activeIncidentCount && ` (${activeIncidentCount})`) || ''}`;
+                    },
+                },
             ]}
             sidebarSections={this.getSidebarSections()}
         />

datahub-web-react/src/app/entity/shared/tabs/Incident/IncidentTab.tsx

@@ -1,6 +1,6 @@
 import React, { useState } from 'react';
 import styled from 'styled-components';
-import { Button, Empty, List, Select, Typography } from 'antd';
+import { Button, Empty, List, Select, Tooltip, Typography } from 'antd';
 import { PlusOutlined } from '@ant-design/icons';
 import { useGetEntityIncidentsQuery } from '../../../../../graphql/incident.generated';
 import TabToolbar from '../../components/styled/TabToolbar';
@@ -78,18 +78,30 @@ export const IncidentTab = () => {
         title: incident?.title,
     }));
 
+    const canEditIncidents = (data?.entity as any)?.privileges?.canEditIncidents || false;
+
     return (
         <>
             <Header>
                 <TabToolbar>
-                    <Button icon={<PlusOutlined />} onClick={() => setIsRaiseIncidentModalVisible(true)} type="text">
-                        Raise Incident
-                    </Button>
-                    <AddIncidentModal
-                        refetch={refetch}
-                        open={isRaiseIncidentModalVisible}
-                        onClose={() => setIsRaiseIncidentModalVisible(false)}
-                    />
+                    <Tooltip
+                        showArrow={false}
+                        title={!canEditIncidents && 'You do not have permission to create an incidents for this asset'}
+                    >
+                        <Button
+                            icon={<PlusOutlined />}
+                            onClick={() => canEditIncidents && setIsRaiseIncidentModalVisible(true)}
+                            type="text"
+                            disabled={!canEditIncidents}
+                        >
+                            Raise Incident
+                        </Button>
+                        <AddIncidentModal
+                            refetch={refetch}
+                            open={isRaiseIncidentModalVisible}
+                            onClose={() => setIsRaiseIncidentModalVisible(false)}
+                        />
+                    </Tooltip>
                 </TabToolbar>
                 <Summary>
                     <IncidentSummary summary={getIncidentsStatusSummary(allIncidents)} />

datahub-web-react/src/app/entity/shared/tabs/Incident/components/AddIncidentModal.tsx

@@ -86,6 +86,7 @@ export const AddIncidentModal = ({ open, onClose, refetch }: AddIncidentProps) =
                         time: Date.now(),
                         actor: user?.urn,
                     },
+                    tags: null,
                 };
                 message.success({ content: 'Incident Added', duration: 2 });
                 analytics.event({

datahub-web-react/src/graphql/fragments.graphql

@@ -1498,6 +1498,7 @@ fragment entityPrivileges on EntityPrivileges {
     canManageEntity
     canManageChildren
     canEditProperties
+    canEditIncidents
 }
 
 fragment businessAttribute on BusinessAttributeAssociation {

datahub-web-react/src/graphql/incident.graphql

@@ -73,5 +73,21 @@ query getEntityIncidents($urn: String!, $start: Int!, $count: Int!, $state: Inci
                 ...incidentsFields
             }
         }
+        ... on MLFeature {
+            incidents(start: $start, count: $count, state: $state) {
+                ...incidentsFields
+            }
+            privileges {
+                canEditIncidents
+            }
+        }
+        ... on MLModel {
+            incidents(start: $start, count: $count, state: $state) {
+                ...incidentsFields
+            }
+            privileges {
+                canEditIncidents
+            }
+        }
     }
 }

datahub-web-react/src/graphql/mlFeature.graphql

@@ -20,5 +20,8 @@ query getMLFeature($urn: String!) {
         forms {
             ...formsFields
         }
+        activeIncidents: incidents(start: 0, count: 1, state: ACTIVE) {
+            total
+        }
     }
 }

datahub-web-react/src/graphql/mlModel.graphql

@@ -34,5 +34,8 @@ query getMLModel($urn: String!) {
         forms {
             ...formsFields
         }
+        activeIncidents: incidents(start: 0, count: 1, state: ACTIVE) {
+            total
+        }
     }
 }

metadata-models/src/main/pegasus/com/linkedin/incident/IncidentInfo.pdl

@@ -45,7 +45,7 @@ record IncidentInfo {
   @Relationship = {
     "/*": {
       "name": "IncidentOn",
-      "entityTypes": [ "dataset", "chart", "dashboard", "dataFlow", "dataJob", "schemaField" ]
+      "entityTypes": [ "dataset", "chart", "dashboard", "dataFlow", "dataJob", "schemaField", "mlModel", "mlFeature" ]
     }
   }
   @Searchable = {

metadata-models/src/main/resources/entity-registry.yml

@@ -358,6 +358,7 @@ entities:
       - structuredProperties
       - forms
       - testResults
+      - incidentsSummary
   - name: mlModelGroup
     category: core
     keyAspect: mlModelGroupKey
@@ -425,6 +426,7 @@ entities:
       - structuredProperties
       - forms
       - testResults
+      - incidentsSummary
   - name: mlPrimaryKey
     category: core
     keyAspect: mlPrimaryKeyKey

metadata-utils/src/main/java/com/linkedin/metadata/authorization/PoliciesConfig.java

@@ -733,10 +733,25 @@ public class PoliciesConfig {
   // ERModelRelationship Privileges
   public static final ResourcePrivileges ER_MODEL_RELATIONSHIP_PRIVILEGES =
       ResourcePrivileges.of(
-          "erModelRelationship",
-          "ERModelRelationship",
-          "update privileges for ermodelrelations",
+          "ER Model Relationships",
+          "",
+          "Privileges for ER Model Relationships",
           COMMON_ENTITY_PRIVILEGES);
+
+  public static final ResourcePrivileges ML_FEATURE_PRIVILEGES =
+          ResourcePrivileges.of(
+                  "mlFeature",
+                  "ML Feature",
+                  "ML Features ingested to DataHub.",
+                  COMMON_ENTITY_PRIVILEGES);
+
+  public static final ResourcePrivileges ML_MODEL_PRIVILEGES =
+          ResourcePrivileges.of(
+                  "mlModel",
+                  "ML Model",
+                  "ML Models ingested to DataHub.",
+                  COMMON_ENTITY_PRIVILEGES);
+
   public static final ResourcePrivileges BUSINESS_ATTRIBUTE_PRIVILEGES =
       ResourcePrivileges.of(
           "businessAttribute",
@@ -767,7 +782,9 @@ public class PoliciesConfig {
           DATA_PRODUCT_PRIVILEGES,
           ER_MODEL_RELATIONSHIP_PRIVILEGES,
           BUSINESS_ATTRIBUTE_PRIVILEGES,
-          STRUCTURED_PROPERTIES_PRIVILEGES);
+          STRUCTURED_PROPERTIES_PRIVILEGES,
+          ML_FEATURE_PRIVILEGES,
+          ML_MODEL_PRIVILEGES);
 
   // Merge all entity specific resource privileges to create a superset of all resource privileges
   public static final ResourcePrivileges ALL_RESOURCE_PRIVILEGES =