Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements to the user pic list selection within entities #11803

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Enhancements to the user pic list selection within entities #11803

wants to merge 7 commits into from
+33 −4

Conversation

Deepalijain13
Copy link

@Deepalijain13 Deepalijain13 commented Nov 6, 2024 •
edited
Loading

Changes
Note: There are a lot of users with identical name so in order to differentiate we have added the username, title and departmentID so that the right owner can be selected by the consumer.

Added username and departmentID and title in the Owners dropdown

image image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Nov 6, 2024
@shirshanka shirshanka added the datahub-community-champion PRs authored by DataHub Community Champions label Nov 13, 2024
@hsheth2 hsheth2 added the needs-review Label for PRs that need review from a maintainer. label Nov 20, 2024
jjoyce0510
jjoyce0510 reviewed Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall approach seems okay. A few suggested changes:

  1. Design: Instead of using dashes to separate each of these items, which makes it a bit long horizontally and difficult to read, I would suggest placing the username, title, and department below if present.
  2. Variable naming

@jjoyce0510
Copy link
Collaborator

One comment, also build & test is failing

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 9, 2024
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabe-lyons gabe-lyons Awaiting requested review from gabe-lyons

@jjoyce0510 jjoyce0510 Awaiting requested review from jjoyce0510

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community datahub-community-champion PRs authored by DataHub Community Champions needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Deepalijain13 @jjoyce0510 @shirshanka @hsheth2