fix(ui) Add backwards compatibility to the UI for old policy filters #12017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datahub-cyborg
bot
added
the
needs-review
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
chriscollins3456
merged commit 11c49ec
into
datahub-project:master
39 of 40 checks passed
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered a bug where old policies with the
RESOURCE_TYPEorRESOURCE_URNfilters applied to them were not being rendered in the UI. These are still supported on the backend, but the UI was saying "All" since it didn't think there was a filter for the types or assets fields.This PR adds that backwards compatibility to the UI by fetching those fields if they exist to display, and when editing these fields we remove the deprecated fields and only use the newer ones going forward.
Checklist