Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(structuredProps) Add frontend for managing structured props and filtering by them #12097

Conversation

chriscollins3456
Copy link
Collaborator

This PR accomplishes a few main objectives:

  1. Adds the UI for structured properties management where you can create, edit, and delete structured properties
  2. Add the functionality for filtering by structured properties in the UI

The UI for managing structured props is almost entirely new code. We have a new page that you can only get to if you have the manage or view privileges for structured properties. Here you can go through the flow of interacting with the structured properties that you have in your instance.

The functionality for filtering by structured properties in the UI required a few backend changes as well as the frontend. Namely, we now pass back an optional entity on facet metadata so we can display the property associated with a particular filter. Then there is related business logic in aggregation query builder to this change. Additionally, we need to request the specific structured properties that have the flag to be a filter turned on, and then request these facets specifically. There was some other logic that needed to change around requesting specific facets and still returning default facets for our main search call.

The next PR will include all of the rest of the display preferences for structured properties.

Screenshots:
image

image image image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Dec 11, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 11, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 11, 2024
@chriscollins3456 chriscollins3456 merged commit 8b5fb71 into datahub-project:master Dec 11, 2024
80 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment pending-submitter-merge product PR or Issue related to the DataHub UI/UX release-0.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants