Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui) Add full support for structured properties on assets #12100

Conversation

chriscollins3456
Copy link
Collaborator

@chriscollins3456 chriscollins3456 commented Dec 12, 2024

This PR adds the final support for adding, editing, removing, and displaying structured properties on assets and schema fields.

We introduce a new and improved Properties tab experience where you can actually add a structured property on an asset from the tab itself. You can also edit and remove a property from the tab there. This is also supported in the schema field drawer on the schema tabs.

Additionally, this PR adds the remainder of the support for the display settings on structured properties. Now when you toggle the appropriate toggles when creating or editing a structured prop, it will:

  • Hide the property from the rest of the UI
  • Show the property as an asset badge (which also is displayed on lineage cards)
  • Show the property in search filters once it's applied to assets (already supported before this PR)
  • Display the property in an asset's sidebar as a native metadata type
  • Display the property in the schema field table as a new native column type

Screenshots:
In here you can see the asset badge, the schema column, and the asset sidebar
image

image image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Dec 12, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 12, 2024
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 12, 2024
@chriscollins3456 chriscollins3456 merged commit dcc8ad9 into datahub-project:master Dec 12, 2024
83 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants