Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bump): bump node version long term support release (build time … #12199

Merged
merged 1 commit into from
Dec 22, 2024
Merged

chore(bump): bump node version long term support release (build time … #12199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ jobs:
run: |
./gradlew :datahub-frontend:build :datahub-web-react:build --parallel
env:
NODE_OPTIONS: "--max-old-space-size=3072"
NODE_OPTIONS: "--max-old-space-size=4096"
- name: Gradle compile (jdk8) for legacy Spark
if: ${{ matrix.command == 'except_metadata_ingestion' && needs.setup.outputs.backend_change == 'true' }}
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker-unified.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ jobs:
./gradlew :datahub-frontend:dist -x test -x yarnTest -x yarnLint --parallel
mv ./datahub-frontend/build/distributions/datahub-frontend-*.zip datahub-frontend.zip
env:
NODE_OPTIONS: "--max-old-space-size=3072"
NODE_OPTIONS: "--max-old-space-size=4096"
- name: Build and push
uses: ./.github/actions/docker-custom-build-and-push
with:
Expand Down
3 changes: 1 addition & 2 deletions datahub-web-react/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ node {
}

// Version of node to use.
version = '21.2.0'
version = '22.12.0'

// Version of Yarn to use.
yarnVersion = '1.22.22'
Expand Down Expand Up @@ -93,7 +93,6 @@ task yarnLintFix(type: YarnTask, dependsOn: [yarnInstall, yarnGenerate]) {
}

task yarnBuild(type: YarnTask, dependsOn: [yarnInstall, yarnGenerate]) {
environment = [NODE_OPTIONS: "--max-old-space-size=3072 --openssl-legacy-provider"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used because of the change to package.json (see below)

args = ['run', 'build']

outputs.cacheIf { true }
Expand Down
2 changes: 1 addition & 1 deletion datahub-web-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"analyze": "source-map-explorer 'dist/assets/*.js'",
"start": "yarn run generate && vite",
"ec2-dev": "yarn run generate && CI=true;export CI;vite",
"build": "yarn run generate && NODE_OPTIONS='--max-old-space-size=3072 --openssl-legacy-provider' CI=false vite build",
"build": "yarn run generate && NODE_OPTIONS='--max-old-space-size=4096 --openssl-legacy-provider' CI=false vite build",
"test": "vitest",
"generate": "graphql-codegen --config codegen.yml",
"lint": "eslint . --ext .ts,.tsx --quiet && yarn format-check && yarn type-check",
Expand Down
2 changes: 1 addition & 1 deletion docs-website/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ node {
}

// Version of node to use.
version = '21.2.0'
version = '22.12.0'

// Version of Yarn to use.
yarnVersion = '1.22.22'
Expand Down
2 changes: 1 addition & 1 deletion smoke-test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ node {
}

// Version of node to use.
version = '21.2.0'
version = '22.12.0'

// Version of Yarn to use.
yarnVersion = '1.22.22'
Expand Down
Loading