Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): consistent fingerprint for sql parsing aggregator #12239

Merged
merged 3 commits into from
Jan 3, 2025
Merged

fix(ingest): consistent fingerprint for sql parsing aggregator #12239

merged 3 commits into from
Jan 3, 2025

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@mayurinehate
fix(ingest): consistent fingerprint for sql parsing aggregator
f5f6267 
Without this - same query passed to add_observed_query and add_known_query_lineage
result in two different query entities
@mayurinehate
fix user email extraction
db4115f
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 30, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 30, 2024
hsheth2
hsheth2 reviewed Dec 30, 2024
View reviewed changes
metadata-ingestion/src/datahub/sql_parsing/sql_parsing_aggregator.py
@@ -848,7 +847,6 @@ def add_preparsed_query(
query_fingerprint = get_query_fingerprint(
parsed.query_text,
platform=self.platform.platform_name,
fast=True,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to revisit this - we want fast fingerprinting for snowflake, and slow parsing-based for all other platforms

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 30, 2024
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jan 2, 2025
@hsheth2 hsheth2 merged commit fba0996 into datahub-project:master Jan 3, 2025
80 of 107 checks passed
@mayurinehate mayurinehate mentioned this pull request Jan 6, 2025
Merged
5 tasks
llance pushed a commit to llance/datahub that referenced this pull request Jan 13, 2025
@mayurinehate @llance
fix(ingest): consistent fingerprint for sql parsing aggregator (datah…
09b371c 
…ub-project#12239)
llance pushed a commit to llance/datahub that referenced this pull request Jan 13, 2025
@mayurinehate @llance
fix(ingest): consistent fingerprint for sql parsing aggregator (datah…
886da27 
…ub-project#12239)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurinehate @hsheth2