Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preset glossary term #12330

Closed
wants to merge 59 commits into from
Closed

Conversation

llance
Copy link
Contributor

@llance llance commented Jan 13, 2025

Checklist

rework of llance#10

after a bunch of refactor.

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 50.38880% with 319 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ingestion/src/datahub/ingestion/source/superset.py 21.34% 70 Missing ⚠️
...data-ingestion/src/datahub/emitter/rest_emitter.py 31.57% 39 Missing ⚠️
...c/datahub/cli/specific/structuredproperties_cli.py 15.90% 37 Missing ⚠️
...ingestion/src/datahub/ingestion/source/aws/glue.py 7.40% 25 Missing ⚠️
...b/ingestion/source/gc/execution_request_cleanup.py 0.00% 19 Missing ⚠️
.../src/datahub/ingestion/source/redshift/redshift.py 0.00% 17 Missing ⚠️
...stion/src/datahub/ingestion/source/unity/source.py 64.10% 14 Missing ⚠️
.../src/datahub/ingestion/source/bigquery_v2/usage.py 38.09% 13 Missing ⚠️
...rch/elasticsearch/indexbuilder/ESIndexBuilder.java 13.33% 13 Missing ⚠️
...tion/src/datahub/ingestion/source/gc/datahub_gc.py 0.00% 11 Missing ⚠️
... and 21 more
Files with missing lines Coverage Δ
metadata-ingestion/src/datahub/cli/delete_cli.py 31.88% <100.00%> (ø)
...ion/api/auto_work_units/auto_ensure_aspect_size.py 93.75% <100.00%> (-6.25%) ⬇️
...data-ingestion/src/datahub/ingestion/api/source.py 99.15% <100.00%> (+<0.01%) ⬆️
...stion/src/datahub/ingestion/glossary/classifier.py 95.45% <ø> (-0.20%) ⬇️
...ta-ingestion/src/datahub/ingestion/graph/config.py 100.00% <100.00%> (ø)
...c/datahub/ingestion/source/bigquery_v2/bigquery.py 90.55% <100.00%> (ø)
...ub/ingestion/source/bigquery_v2/bigquery_config.py 86.69% <100.00%> (-5.84%) ⬇️
...ub/ingestion/source/bigquery_v2/bigquery_report.py 100.00% <ø> (ø)
...rc/datahub/ingestion/source/bigquery_v2/lineage.py 33.57% <100.00%> (-30.66%) ⬇️
...ahub/ingestion/source/cassandra/cassandra_utils.py 96.15% <ø> (-0.15%) ⬇️
... and 45 more

... and 362 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e2c49...2d089aa. Read the comment docs.

mayurinehate and others added 18 commits January 13, 2025 14:46
anshbansal and others added 29 commits January 13, 2025 14:46
@llance llance closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.