-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: remove black in favor of ruff for formatting #12378
Conversation
@@ -29,30 +37,21 @@ classes = ["typing"] | |||
|
|||
[tool.ruff.lint] | |||
select = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw we should be using extend-select everywhere instead of select
"B019", | ||
# Allow function call in argument defaults | ||
"B008", | ||
"E501", # Line length violations (handled by formatter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also want to make sure you've seen https://docs.astral.sh/ruff/formatter/#conflicting-lint-rules
See my comments here #12364 (comment) |
Put some fixes in #12382 |
Checklist