Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: remove black in favor of ruff for formatting #12378

Merged
merged 24 commits into from
Jan 18, 2025

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@anshbansal anshbansal changed the title dev: remove black from smoke-test dev: remove black Jan 17, 2025
@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata smoke_test Contains changes related to smoke tests labels Jan 17, 2025
@anshbansal anshbansal marked this pull request as ready for review January 17, 2025 19:21
@anshbansal anshbansal changed the title dev: remove black dev: remove black in favor of ruff for formatting Jan 17, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 17, 2025
@@ -29,30 +37,21 @@ classes = ["typing"]

[tool.ruff.lint]
select = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw we should be using extend-select everywhere instead of select

https://docs.astral.sh/ruff/settings/#lint_extend-select

"B019",
# Allow function call in argument defaults
"B008",
"E501", # Line length violations (handled by formatter)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 76.08696% with 55 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...gestion/src/datahub/ingestion/source/salesforce.py 25.00% 6 Missing ⚠️
.../src/datahub/ingestion/source/redshift/redshift.py 0.00% 4 Missing ⚠️
metadata-ingestion/src/datahub/lite/duckdb_lite.py 0.00% 4 Missing ⚠️
...gestion/src/datahub/ingestion/source/abs/source.py 0.00% 3 Missing ⚠️
...-ingestion/src/datahub/ingestion/source/openapi.py 0.00% 3 Missing ⚠️
metadata-ingestion/src/datahub/cli/docker_cli.py 0.00% 2 Missing ⚠️
metadata-ingestion/src/datahub/cli/lite_cli.py 0.00% 2 Missing ⚠️
...ahub/ingestion/source/confluent_schema_registry.py 0.00% 2 Missing ⚠️
...ingestion/source/snowflake/snowflake_connection.py 0.00% 2 Missing ⚠️
metadata-ingestion/src/datahub/cli/migrate.py 0.00% 1 Missing ⚠️
... and 26 more
Files with missing lines Coverage Δ
...w-plugin/src/datahub_airflow_plugin/_extractors.py 84.54% <100.00%> (ø)
...gin/src/datahub_airflow_plugin/datahub_listener.py 68.08% <100.00%> (ø)
...n/src/datahub_airflow_plugin/datahub_plugin_v22.py 59.77% <100.00%> (ø)
...datahub_dagster_plugin/client/dagster_generator.py 57.89% <ø> (ø)
.../datahub_dagster_plugin/sensors/datahub_sensors.py 50.18% <ø> (ø)
...-modules/gx-plugin/src/datahub_gx_plugin/action.py 81.65% <100.00%> (ø)
...fect-plugin/src/prefect_datahub/datahub_emitter.py 89.20% <100.00%> (ø)
...tahub/api/entities/assertion/assertion_operator.py 72.72% <100.00%> (ø)
...ub/api/entities/datacontract/assertion_operator.py 79.72% <100.00%> (ø)
...rc/datahub/api/entities/dataproduct/dataproduct.py 76.71% <100.00%> (ø)
... and 134 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d6169...d8def88. Read the comment docs.

@hsheth2
Copy link
Collaborator

hsheth2 commented Jan 17, 2025

See my comments here #12364 (comment)

@hsheth2
Copy link
Collaborator

hsheth2 commented Jan 17, 2025

Put some fixes in #12382

@anshbansal anshbansal merged commit 262dd76 into master Jan 18, 2025
193 of 195 checks passed
@anshbansal anshbansal deleted the ab-2025-jan-18-black-remove branch January 18, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge smoke_test Contains changes related to smoke tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants