[helm/affinity] - Updates to iam jupyter operator charts

[tyu0912]

Hi guys, I made a couple updates to the helm chart for iam , jupyter, and operator services. Details are below. Let me know what you guys think.

Update 1: Introduced with blocks to simplify addition of objects like resources, volumeMounts, and affinity. The with block provides scoping and also will take into account with a variable exists so no need for additional conditionals.

{{- with .Values.iam.resources }}
resources: {{- toYaml . | nindent 12 }}
{{- end }}

Update 2: Replaced environment variable specification to using a loop. This essentially removes the manual need to specify environment variables in both the values.yaml file and the deployment.yaml file making the chart easier to maintain and more dynamic.

{{- if or .Values.iam.env .Values.iam.envValueFrom }}
env:
  {{- range $key, $value := .Values.iam.envValueFrom }}
  - name: {{ $key }}
    valueFrom: {{- $value | toYaml | nindent 16 }}
  {{- end }}
  {{- range $key, $value := .Values.iam.env }}
  - name: {{ $key }}
    value: {{ $value | quote }}
  {{- end }}
{{- end }}

Update 3: Introduced helm unittests action and actual tests to confirm my changes. Details for the package can be found here https://github.com/helm-unittest/helm-unittest. The flow right now is that unittest will be via Github Actions every time a PR is opened, re-opened, etc.

Update 4: Set a default for namespace where if you specify such a value, it will take that. Otherwise, it will take the one defined in the release. Similarly patched up a role in operator helm chart that had a TODO.

Update 5: Patched in iam chart where the traefik middleware was being deployed all the time. Updated it so it only deploys if traefik is the ingressclass.

[echarles]

Update 1: Introduced with blocks to simplify addition of objects like resources, volumeMounts, and affinity. The with block provides scoping and also will take into account with a variable exists so no need for additional conditionals.

Looks great.

Update 2: Replaced environment variable specification to using a loop. This essentially removes the manual need to specify environment variables in both the values.yaml file and the deployment.yaml file making the chart easier to maintain and more dynamic.

Much better, the manual process was tedious. Thank you so much 💯

Update 3: Introduced helm unittests action and actual tests to confirm my changes. Details for the package can be found here https://github.com/helm-unittest/helm-unittest. The flow right now is that unittest will be via Github Actions every time a PR is opened, re-opened, etc.

Excellent.

Update 4: Set a default for namespace where if you specify such a value, it will take that. Otherwise, it will take the one defined in the release. Similarly patched up a role in operator helm chart that had a TODO.

We have not been good at defaults, so yes, this is great.

Update 5: Patched in iam chart where the traefik middleware was being deployed all the time. Updated it so it only deploys if traefik is the ingressclass.

Awesome (actually the value should be datalayer-traefik I see you make the correct change in the PR)

[echarles]

LGTM Thx @tyu0912