-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple enhancements #9
Conversation
fcollonval
commented
May 13, 2024
- Use a execution stack to avoid trouble for long running cells (fixes Should code be executed asynchronously in RTC mode? #7 )
- Concatenate stream outputs
- Support clear_output
- Attempt to support stdin (not working currently)
Thanks for the mention. For stdin issue, it seems that the problem is the timing of the stdin input? In my understanding, with the help of the front-end, the user should be able to input stdin via front-end. Without a front-end or any interaction page (which can be something like a terminal), it might be hard to support this feature. |
Not sure to understand. But the main problem is that we have no idea ahead of execution if a snippet will prompt for stdin. So the execution request caller should interrogate the server or be notified when such event occurs.
With the above mentioned mechanism, any case is supported. Although how to prompt for user input is gonna changed depending on the front end. |
Yes, that's what I meant. Actually it was this PR that reminded me of it. (Probably because I've basically never used inputs in Jupyter..)
And it depends on when the client (front-end) sends, which means that the front-end still needs to listen to the websocket and display the input prompt box. 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thx @fcollonval
@Wh1isper It requires fetching a status endpoint. See that sequence diagram: https://github.com/datalayer/jupyter-server-nbmodel?tab=readme-ov-file#with-input-case You can see an updated demo there |
Nice |