Skip to content

Commit

Permalink
chore: lint
Browse files Browse the repository at this point in the history
  • Loading branch information
echarles committed Oct 18, 2023
1 parent 524ad29 commit e1a55ab
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
6 changes: 3 additions & 3 deletions docs/docs/develop/setup/devcontainers.mdx
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
---
title: VS Code devcontainers
title: VS Code Devcontainers
sidebar_position: 2
---

# Setup with VS Code devcontainers
# Setup with VS Code Devcontainers

Clone the `jupyter-ui` repository and load it in your VS Code.

Expand All @@ -12,7 +12,7 @@ git clone https://github.com/datalayer/jupyter-ui.git && \
cd jupyter-ui
```

The [Jupyter UI](https://github.com/datalayer/jupyter-ui) repository ships the needed `.devcontainer` folder to develop from [VS Code devcontainers](https://code.visualstudio.com/docs/devcontainers/containers).
The [Jupyter UI](https://github.com/datalayer/jupyter-ui) repository ships the needed `.devcontainer` folder to develop from [VS Code Devcontainers](https://code.visualstudio.com/docs/devcontainers/containers).

Just click on the bottom-left blue icon in your VS Code and select `Reopen in container...`

Expand Down
2 changes: 1 addition & 1 deletion docs/docs/develop/setup/index.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Many developers are reporting issues with their environment (build failures...).

Choose the way you want to develop Jupyter UI:

1. [With VS Code devcontainers](/docs/develop/setup/devcontainers)
1. [With VS Code Devcontainers](/docs/develop/setup/devcontainers)
1. [With Conda](/docs/develop/setup/conda)

Once you have applied the steps described in one of the above 2 options, you are ready to develop following the next steps.
Expand Down
5 changes: 0 additions & 5 deletions packages/lexical/src/jupyter/lab/handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,27 +20,22 @@ export async function requestAPI<T>(
'jupyter_lexical', // API Namespace
endPoint
);

let response: Response;
try {
response = await ServerConnection.makeRequest(requestUrl, init, settings);
} catch (error: any) {
throw new ServerConnection.NetworkError(error);
}

let data: any = await response.text();

if (data.length > 0) {
try {
data = JSON.parse(data);
} catch (error) {
console.log('Not a JSON response body.', response);
}
}

if (!response.ok) {
throw new ServerConnection.ResponseError(response, data.message || data);
}

return data;
}

0 comments on commit e1a55ab

Please sign in to comment.