Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First iteration to sync primer react with JupyterLab theme #132

Merged
merged 1 commit into from
Dec 15, 2023
Merged

First iteration to sync primer react with JupyterLab theme #132

merged 1 commit into from
Dec 15, 2023

Conversation

fcollonval
Copy link
Member

Set design tokens of primer react with the one of JupyterLab to more homogeneous look and feel.

Fixes partly #115; some design tokens were not assigned and will certainly require follow-up work.

@fcollonval fcollonval added the feature New feature or request label Dec 15, 2023
@fcollonval fcollonval requested a review from echarles December 15, 2023 15:48
echarles
echarles approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @fcollonval

@echarles echarles merged commit f9091ad into datalayer:main Dec 15, 2023
5 checks passed
@fcollonval fcollonval deleted the ft/apply-jp-theme-to-primer-react branch December 17, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarles echarles echarles approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcollonval @echarles