Switch default values to UTC, and add sub-second values #80
Conversation
| @@ -210,18 +210,20 @@ VALUE data_objects_parse_time(const char *date) { | |||
| return Qnil; | |||
| } | |||
|
|
|||
| // TODO: support the timezone being returned from | |||
| return rb_funcall(rb_cTime, rb_intern("local"), 7, INT2NUM(year), INT2NUM(month), INT2NUM(day), INT2NUM(hour), INT2NUM(min), INT2NUM(sec), INT2NUM(usec)); | |||
There was a problem hiding this comment.
So, this local call doesn't support setting the timezone AFAIK.
There was a problem hiding this comment.
Yeah, we'd need to handle the cases different here then. Use local when there's no UTC offset present, but build an object with the specific UTC offset otherwise.
|
Hrm. TravisCI appears to be randomly killing the build after that last push. |
|
@tpitale What do you mean with killing the build? |
|
The builds stopped at random places, and the last thing in the log is: 'The build has been terminated'. https://travis-ci.org/datamapper/do/jobs/54308706#L573 |
|
@tpitale I suspect something might be broken then that causes it to hang indefinitely and then Travis aborts it. I suspect it's a problem with the changes, not with Travis. Might have some time tomorrow to run this and see if there's anything standing out. |
|
Yeah, the specs stalled for me locally after that change. I'll dig in when I get home tonight. I had to reinstall my MySQL. |
|
Okay, I reverted that change from yesterday. Now I'm trying to figure out how to get mysql to work in UTC. It's just insanity. |
|
I don't think it's possible for mysql to share specs with postgresql and use a time zone other than local system time. |
First pass, we probably need more specs in different timezones, and more structure between
TimeandDateTime.Please let me know what you think @dbussink. This is passing when I run
bundle exec rake specfrom withindo_postgres.