Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue #117 #108

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Fix the issue #117 #108

merged 2 commits into from
Sep 11, 2024

Conversation

alkorolyov
Copy link
Contributor

Simple fix for an existing issue with 'morgan' kind in FPVecTransformer (#107)

Changelogs

  • enumerate the changes of that PR.

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted. Eventually consider making a new tutorial for new features.
  • Write concise and explanatory changelogs below.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

Simple fix for an existing issue with 'morgan' kind in FPVecTransformer 
datamol-io#107
@maclandrol
Copy link
Member

Good catch @alkorolyov ! Thanks for the PR

Copy link
Contributor

@zhu0619 zhu0619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
@alkorolyov Thank you for fixing this!

@maclandrol maclandrol merged commit 44ffd6d into datamol-io:main Sep 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants