Skip to content

Commit

Permalink
feat: remove warning (#104)
Browse files Browse the repository at this point in the history
Remove a warning that a categorical column with many categories is used
for coloring of TS line plot.
Following #94, which removes most of the warnings, the warning here is
removed since it does not bring relevant information to the user (the
user can see that there are many colors), and makes the final reports
ugly.
  • Loading branch information
mbelak-dtml authored Sep 7, 2023
1 parent 7e9cd46 commit 3c33b6e
Showing 1 changed file with 0 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
"""Time series line plot package."""

import warnings
from typing import Any, Dict, List, Optional

import nbformat.v4 as nbfv4
Expand Down Expand Up @@ -116,8 +115,6 @@ def _time_series_line_plot_colored(df, columns=None, color_col=None):
layout = dict(xaxis_rangeslider_visible=True)
if not is_categorical(df[color_col]):
raise ValueError(f"Cannot color by non-categorical column `{color_col}`")
if df[color_col].nunique() > 20:
warnings.warn("Coloring by categorical column with many unique values!")
df_color_shifted = df[color_col].shift(-1)
for col in columns:
data = [
Expand Down

0 comments on commit 3c33b6e

Please sign in to comment.