Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dismiss pull request approval on PR title change #116

Closed
mbelak-dtml opened this issue Sep 4, 2023 · 0 comments · Fixed by #123
Closed

Dismiss pull request approval on PR title change #116

mbelak-dtml opened this issue Sep 4, 2023 · 0 comments · Fixed by #123
Assignees
@mbelak-dtml
Labels
ci Fixes or improvements to GitHub Actions

Comments

@mbelak-dtml
Copy link
Collaborator

Since the PR title is used as the commit message after a PR is merged to main, any change to the title should dismiss approvals to prevent merging a PR with a title which was not approved.

See cli/cli#2342, #113 (comment)
@mbelak-dtml mbelak-dtml added the ci Fixes or improvements to GitHub Actions label Sep 4, 2023
@mbelak-dtml mbelak-dtml mentioned this issue Sep 4, 2023
Merged
@mbelak-dtml mbelak-dtml self-assigned this Sep 8, 2023
@mbelak-dtml mbelak-dtml linked a pull request Sep 8, 2023 that will close this issue
ci: Dismiss PR approval on edit #123
Merged
@mbelak-dtml mbelak-dtml mentioned this issue Sep 8, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 11, 2023
@mbelak-dtml
ci: Dismiss PR approval on edit (#123)
92e41f3 
Resolves #116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbelak-dtml mbelak-dtml

Labels
ci Fixes or improvements to GitHub Actions
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Dismiss PR approval on edit datamole-ai/edvart
1 participant
@mbelak-dtml