Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run test workflow on PR edited #113

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

mbelak-dtml
Copy link
Collaborator

@mbelak-dtml mbelak-dtml commented Aug 31, 2023

By default pull request triggers on event types opened, reopened, synchronize.
See https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request
Added also trigger on event type edited.

Resolves #87

@mbelak-dtml mbelak-dtml self-assigned this Aug 31, 2023
@mbelak-dtml mbelak-dtml changed the title ci: run test workflow on PR edited ci: run test workflow on PR edited (test rename) Aug 31, 2023
@mbelak-dtml mbelak-dtml force-pushed the ci/run-test-on-pull-request-edited branch from e0ea7e8 to a2bf16b Compare August 31, 2023 09:00
@mbelak-dtml mbelak-dtml changed the title ci: run test workflow on PR edited (test rename) ci: run test workflow on PR edited Aug 31, 2023
By default pull request triggers on event types `opened`, `reopened`, `synchronize`.
See https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request
Added also trigger on event type `edited`.

Resolves #87
@mbelak-dtml mbelak-dtml force-pushed the ci/run-test-on-pull-request-edited branch from a2bf16b to efa2075 Compare August 31, 2023 09:02
@mbelak-dtml mbelak-dtml marked this pull request as ready for review August 31, 2023 09:02
Copy link
Contributor

@lukany lukany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd copy the commit's description into PR description.

@lukany
Copy link
Contributor

lukany commented Sep 4, 2023

It might also be good to dismiss PR approval if PR's title or description is edited. There seems to be no official way to do it but I found a snippet here: cli/cli#2342

@mbelak-dtml
Copy link
Collaborator Author

It might also be good to dismiss PR approval if PR's title or description is edited. There seems to be no official way to do it but I found a snippet here: cli/cli#2342

Good point, created an issue #116

@mbelak-dtml
Copy link
Collaborator Author

I'd copy the commit's description into PR description.

Done

@lukany lukany added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit b1972d1 Sep 6, 2023
10 checks passed
@lukany lukany deleted the ci/run-test-on-pull-request-edited branch September 6, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Renaming PR does not trigger CI check for PR title
2 participants