feat!: remove parameter string_representation from infer_data_type
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces two calls to `infer_data_type`, once with `string_representation=True` and once with `string_representation=False`.
mbelak-dtml
force-pushed
the
feat/data-types-remove-string-repr
branch
2 times, most recently
from
5a350e8
to
98632ae
Compare
The parameter is no longer used by in `edvart`. BREAKING CHANGE: Parameter `string_representation` of `edvart.data_types.infer_data_type` removed. Call `str` on the result instead to get the string representation.
mbelak-dtml
force-pushed
the
feat/data-types-remove-string-repr
branch
from
98632ae
to
02a5fe7
Compare
lukany
approved these changes
Sep 4, 2023
|
Nice split into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter is no longer used in
edvart.BREAKING CHANGE: Parameter
string_representationofedvart.data_types.infer_data_typeremoved.Call
stron the result instead to get the string representation.