Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use mypy type checking #218

Merged
merged 10 commits into from
Mar 14, 2024
Merged

refactor: use mypy type checking #218

merged 10 commits into from
Mar 14, 2024

Conversation

mbelak-dtml
Copy link
Collaborator

  • add proper type hints
  • add mypy type checking to CI

@mbelak-dtml mbelak-dtml self-assigned this Mar 6, 2024
@mbelak-dtml
refactor: use mypy type checking
2503421 
* add proper type hints
* add mypy type checking to CI
@mbelak-dtml mbelak-dtml marked this pull request as ready for review March 8, 2024 09:39
@mbelak-dtml mbelak-dtml requested a review from lukany as a code owner March 8, 2024 09:39
lukany
lukany requested changes Mar 12, 2024
View reviewed changes
edvart/report.py Show resolved Hide resolved
edvart/report_sections/dataset_overview.py Outdated Show resolved Hide resolved
edvart/report_sections/univariate_analysis.py Show resolved Hide resolved
@mbelak-dtml mbelak-dtml requested a review from lukany March 12, 2024 16:46
@lukany lukany added this pull request to the merge queue Mar 14, 2024
Merged via the queue into main with commit 5f07d78 Mar 14, 2024
6 checks passed
@lukany lukany deleted the refactor/mypy branch March 14, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukany lukany lukany approved these changes

Assignees

@mbelak-dtml mbelak-dtml

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbelak-dtml @lukany