Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split scatter_plot_2d into 2 functions. #39

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

mbelak-dtml
Copy link
Collaborator

The scatter plot has an interactive and a non-interactive version. The top-level function now just deciedes which of the two new functions to call.

@mbelak-dtml mbelak-dtml self-assigned this Jul 28, 2023
@mbelak-dtml mbelak-dtml requested a review from lukany July 28, 2023 11:45
edvart/plots.py Show resolved Hide resolved
edvart/plots.py Show resolved Hide resolved
edvart/plots.py Show resolved Hide resolved
Copy link
Contributor

@lukany lukany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts 🥲

The scatter plot has an interactive and a non-interactive version.
The top-level function now just deciedes which of the two new functions to call.
@lukany lukany added this pull request to the merge queue Aug 1, 2023
Merged via the queue into datamole-ai:main with commit 34195cf Aug 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants