refactor!: Remove utils.pair_plot function
#92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function is a single line and does not belong in `utils` module. Moved the implementation directly to the only place where it is called: `bivariate_analysis.PairPlot`.
lukany
previously approved these changes
Sep 6, 2023
lukany
approved these changes
Sep 6, 2023
lukany
requested changes
Sep 6, 2023
Good catch. Updated the PR description. |
lukany
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function is a single line and does not belong in
utilsmodule. Moved the implementation directly to the only place where it is called:edvart.bivariate_analysis.PairPlot.BREAKING CHANGE: The function
utils.pair_plotis removed.