Skip to content

Commit

Permalink
migrate commands to v5
Browse files Browse the repository at this point in the history
  • Loading branch information
potatoqualitee committed Oct 25, 2024
1 parent 9765c9f commit 9eadcd1
Show file tree
Hide file tree
Showing 4 changed files with 216 additions and 84 deletions.
90 changes: 55 additions & 35 deletions tests/Add-DbaAgDatabase.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -2,58 +2,78 @@
param($ModuleName = 'dbatools')
$global:TestConfig = Get-TestConfig

Describe "Add-DbaAgDatabase" {
Context "Validate parameters" {
Describe "Add-DbaAgDatabase" -Tag "UnitTests" {
Context "Parameter validation" {
BeforeAll {
$command = Get-Command Add-DbaAgDatabase
$expectedParameters = $TestConfig.CommonParameters

$expectedParameters += @(
"SqlInstance",
"SqlCredential",
"AvailabilityGroup",
"Database",
"Secondary",
"SecondarySqlCredential",
"InputObject",
"SeedingMode",
"SharedPath",
"UseLastBackup",
"AdvancedBackupParams",
"EnableException"
)
}

It "Should have exactly the expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
}
$parms = @(
"SqlInstance",
"SqlCredential",
"AvailabilityGroup",
"Database",
"Secondary",
"SecondarySqlCredential",
"InputObject",
"SeedingMode",
"SharedPath",
"UseLastBackup",
"AdvancedBackupParams",
"EnableException",
"WhatIf",
"Confirm"
)
It "Has required parameter: <_>" -ForEach $parms {

It "Has parameter: <_>" -ForEach $expectedParameters {
$command | Should -HaveParameter $PSItem
}
}
}

Context "Integration Tests" -Tag "IntegrationTests" {
BeforeAll {
$null = Get-DbaProcess -SqlInstance $TestConfig.instance3 -Program 'dbatools PowerShell module - dbatools.io' | Stop-DbaProcess -WarningAction SilentlyContinue
$server = Connect-DbaInstance -SqlInstance $TestConfig.instance3
$agname = "dbatoolsci_addagdb_agroup"
$dbname = "dbatoolsci_addagdb_agroupdb"
$newdbname = "dbatoolsci_addag_agroupdb_2"
$server.Query("create database $dbname")
$backup = Get-DbaDatabase -SqlInstance $TestConfig.instance3 -Database $dbname | Backup-DbaDatabase
$ag = New-DbaAvailabilityGroup -Primary $TestConfig.instance3 -Name $agname -ClusterType None -FailoverMode Manual -Database $dbname -Confirm:$false -Certificate dbatoolsci_AGCert
Describe "Add-DbaAgDatabase" -Tag "IntegrationTests" {
BeforeAll {
$null = Get-DbaProcess -SqlInstance $TestConfig.instance3 -Program 'dbatools PowerShell module - dbatools.io' | Stop-DbaProcess -WarningAction SilentlyContinue
$server = Connect-DbaInstance -SqlInstance $TestConfig.instance3
$agname = "dbatoolsci_addagdb_agroup"
$dbname = "dbatoolsci_addagdb_agroupdb"
$newdbname = "dbatoolsci_addag_agroupdb_2"
$server.Query("create database $dbname")
$backup = Get-DbaDatabase -SqlInstance $TestConfig.instance3 -Database $dbname | Backup-DbaDatabase
$splat = @{
Primary = $TestConfig.instance3
Name = $agname
ClusterType = "None"
FailoverMode = "Manual"
Database = $dbname
Confirm = $false
Certificate = "dbatoolsci_AGCert"
}
$ag = New-DbaAvailabilityGroup @splat
}

AfterAll {
$null = Remove-DbaAvailabilityGroup -SqlInstance $server -AvailabilityGroup $agname -Confirm:$false
$null = Remove-DbaDatabase -SqlInstance $server -Database $dbname, $newdbname -Confirm:$false
}
AfterAll {
$null = Remove-DbaAvailabilityGroup -SqlInstance $server -AvailabilityGroup $agname -Confirm:$false
$null = Remove-DbaDatabase -SqlInstance $server -Database $dbname, $newdbname -Confirm:$false
}

It "adds ag db and returns proper results" {
Context "When adding a database to an availability group" {
BeforeAll {
$server.Query("create database $newdbname")
$backup = Get-DbaDatabase -SqlInstance $TestConfig.instance3 -Database $newdbname | Backup-DbaDatabase
$results = Add-DbaAgDatabase -SqlInstance $TestConfig.instance3 -AvailabilityGroup $agname -Database $newdbname -Confirm:$false
}

It "Adds the database to the availability group" {
$results.AvailabilityGroup | Should -Be $agname
$results.Name | Should -Be $newdbname
$results.IsJoined | Should -Be $true
}
}
}

#$TestConfig.instance2 for appveyor
#$TestConfig.instance2 for appveyor
67 changes: 53 additions & 14 deletions tests/Add-DbaAgListener.Tests.ps1
Original file line number Diff line number Diff line change
@@ -1,33 +1,72 @@
$CommandName = $MyInvocation.MyCommand.Name.Replace(".Tests.ps1", "")
Write-Host -Object "Running $PSCommandpath" -ForegroundColor Cyan
#Requires -Module @{ ModuleName="Pester"; ModuleVersion="5.0"}
param($ModuleName = "dbatools")
$global:TestConfig = Get-TestConfig

Describe "$CommandName Unit Tests" -Tag 'UnitTests' {
Context "Validate parameters" {
[object[]]$params = (Get-Command $CommandName).Parameters.Keys | Where-Object { $_ -notin ('whatif', 'confirm') }
[object[]]$knownParameters = 'SqlInstance', 'SqlCredential', 'AvailabilityGroup', 'Name', 'IPAddress', 'SubnetIP', 'SubnetMask', 'Port', 'Dhcp', 'Passthru', 'InputObject', 'EnableException'
$knownParameters += [System.Management.Automation.PSCmdlet]::CommonParameters
It "Should only contain our specific parameters" {
(@(Compare-Object -ReferenceObject ($knownParameters | Where-Object { $_ }) -DifferenceObject $params).Count ) | Should Be 0
Describe "Add-DbaAgListener" -Tag "UnitTests" {
Context "Parameter validation" {
BeforeAll {
$command = Get-Command Add-DbaAgListener
$expectedParameters = $TestConfig.CommonParameters

$expectedParameters += @(
"SqlInstance",
"SqlCredential",
"AvailabilityGroup",
"Name",
"IPAddress",
"SubnetIP",
"SubnetMask",
"Port",
"Dhcp",
"Passthru",
"InputObject",
"EnableException"
)
}

It "Should have exactly the expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
}

It "Has parameter: <_>" -ForEach $expectedParameters {
$command | Should -HaveParameter $PSItem
}
}
}

Describe "$commandname Integration Tests" -Tag "IntegrationTests" {
Describe "Add-DbaAgListener" -Tag "IntegrationTests" {
BeforeAll {
$agname = "dbatoolsci_ag_newlistener"
$listenerName = 'dbatoolsci_listener'
$ag = New-DbaAvailabilityGroup -Primary $TestConfig.instance3 -Name $agname -ClusterType None -FailoverMode Manual -Confirm:$false -Certificate dbatoolsci_AGCert
$splat = @{
Primary = $TestConfig.instance3
Name = $agname
ClusterType = "None"
FailoverMode = "Manual"
Certificate = "dbatoolsci_AGCert"
Confirm = $false
}
$ag = New-DbaAvailabilityGroup @splat
}

AfterEach {
$null = Remove-DbaAgListener -SqlInstance $TestConfig.instance3 -Listener $listenerName -AvailabilityGroup $agname -Confirm:$false
}

AfterAll {
$null = Remove-DbaAvailabilityGroup -SqlInstance $TestConfig.instance3 -AvailabilityGroup $agname -Confirm:$false
}
Context "creates a listener" {
It "returns results with proper data" {
$results = $ag | Add-DbaAgListener -Name $listenerName -IPAddress 127.0.20.1 -Port 14330 -Confirm:$false

Context "When creating a listener" {
It "Returns results with proper data" {
$splat = @{
Name = $listenerName
IPAddress = "127.0.20.1"
Port = 14330
Confirm = $false
}
$results = $ag | Add-DbaAgListener @splat
$results.PortNumber | Should -Be 14330
}
}
Expand Down
92 changes: 71 additions & 21 deletions tests/Add-DbaAgReplica.Tests.ps1
Original file line number Diff line number Diff line change
@@ -1,46 +1,96 @@
$CommandName = $MyInvocation.MyCommand.Name.Replace(".Tests.ps1", "")
Write-Host -Object "Running $PSCommandpath" -ForegroundColor Cyan
#Requires -Module @{ ModuleName="Pester"; ModuleVersion="5.0"}
param($ModuleName = "dbatools")
$global:TestConfig = Get-TestConfig

Describe "$commandname Unit Tests" -Tag 'UnitTests' {
Context "Validate parameters" {
[object[]]$params = (Get-Command $CommandName).Parameters.Keys | Where-Object { $_ -notin ('whatif', 'confirm') }
[object[]]$knownParameters = 'SqlInstance', 'SqlCredential', 'Name', 'ClusterType', 'AvailabilityMode', 'FailoverMode', 'BackupPriority', 'ConnectionModeInPrimaryRole', 'ConnectionModeInSecondaryRole', 'SeedingMode', 'Endpoint', 'EndpointUrl', 'Passthru', 'ReadOnlyRoutingList', 'ReadonlyRoutingConnectionUrl', 'Certificate', 'ConfigureXESession', 'SessionTimeout', 'InputObject', 'EnableException'
$knownParameters += [System.Management.Automation.PSCmdlet]::CommonParameters
It "Should only contain our specific parameters" {
(@(Compare-Object -ReferenceObject ($knownParameters | Where-Object { $_ }) -DifferenceObject $params).Count ) | Should Be 0
Describe "Add-DbaAgReplica" -Tag "UnitTests" {
Context "Parameter validation" {
BeforeAll {
$command = Get-Command Add-DbaAgReplica
$expectedParameters = $TestConfig.CommonParameters

$expectedParameters += @(
"SqlInstance",
"SqlCredential",
"Name",
"ClusterType",
"AvailabilityMode",
"FailoverMode",
"BackupPriority",
"ConnectionModeInPrimaryRole",
"ConnectionModeInSecondaryRole",
"SeedingMode",
"Endpoint",
"EndpointUrl",
"Passthru",
"ReadOnlyRoutingList",
"ReadonlyRoutingConnectionUrl",
"Certificate",
"ConfigureXESession",
"SessionTimeout",
"InputObject",
"EnableException"
)
}

It "Should have exactly the expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
}

It "Has parameter: <_>" -ForEach $expectedParameters {
$command | Should -HaveParameter $PSItem
}
}
}
Describe "$commandname Integration Tests" -Tag "IntegrationTests" {

Describe "Add-DbaAgReplica" -Tag "IntegrationTests" {
BeforeAll {
$agname = "dbatoolsci_agroup"
$ag = New-DbaAvailabilityGroup -Primary $TestConfig.instance3 -Name $agname -ClusterType None -FailoverMode Manual -Certificate dbatoolsci_AGCert -Confirm:$false
$splat = @{
Primary = $TestConfig.instance3
Name = $agname
ClusterType = "None"
FailoverMode = "Manual"
Certificate = "dbatoolsci_AGCert"
Confirm = $false
}
$ag = New-DbaAvailabilityGroup @splat
$replicaName = $ag.PrimaryReplica
}

AfterAll {
$null = Remove-DbaAvailabilityGroup -SqlInstance $TestConfig.instance3 -AvailabilityGroup $agname -Confirm:$false
Remove-DbaAvailabilityGroup -SqlInstance $TestConfig.instance3 -AvailabilityGroup $agname -Confirm:$false
}
Context "gets ag replicas" {
# the only way to test, really, is to call New-DbaAvailabilityGroup which calls Add-DbaAgReplica
$agname = "dbatoolsci_add_replicagroup"
$ag = New-DbaAvailabilityGroup -Primary $TestConfig.instance3 -Name $agname -ClusterType None -FailoverMode Manual -Certificate dbatoolsci_AGCert -Confirm:$false
$replicaName = $ag.PrimaryReplica

It "returns results with proper data" {
Context "When adding AG replicas" {
BeforeAll {
$agname = "dbatoolsci_add_replicagroup"
$splat = @{
Primary = $TestConfig.instance3
Name = $agname
ClusterType = "None"
FailoverMode = "Manual"
Certificate = "dbatoolsci_AGCert"
Confirm = $false
}
$ag = New-DbaAvailabilityGroup @splat
$replicaName = $ag.PrimaryReplica
}

It "Returns results with proper data" {
$results = Get-DbaAgReplica -SqlInstance $TestConfig.instance3
$results.AvailabilityGroup | Should -Contain $agname
$results.Role | Should -Contain 'Primary'
$results.AvailabilityMode | Should -Contain 'SynchronousCommit'
$results.FailoverMode | Should -Contain 'Manual'
}
It "returns just one result" {

It "Returns just one result" {
$results = Get-DbaAgReplica -SqlInstance $TestConfig.instance3 -Replica $replicaName -AvailabilityGroup $agname
$results.AvailabilityGroup | Should -Be $agname
$results.Role | Should -Be 'Primary'
$results.AvailabilityMode | Should -Be 'SynchronousCommit'
$results.FailoverMode | Should -Be 'Manual'
}
}
} #$TestConfig.instance2 for appveyor

}
51 changes: 37 additions & 14 deletions tests/Add-DbaComputerCertificate.Tests.ps1
Original file line number Diff line number Diff line change
@@ -1,30 +1,53 @@
$CommandName = $MyInvocation.MyCommand.Name.Replace(".Tests.ps1", "")
Write-Host -Object "Running $PSCommandPath" -ForegroundColor Cyan
#Requires -Module @{ ModuleName="Pester"; ModuleVersion="5.0"}
param($ModuleName = "dbatools")
$global:TestConfig = Get-TestConfig

Describe "$CommandName Unit Tests" -Tag 'UnitTests' {
Context "Validate parameters" {
[object[]]$params = (Get-Command $CommandName).Parameters.Keys | Where-Object {$_ -notin ('whatif', 'confirm')}
[object[]]$knownParameters = 'ComputerName', 'Credential', 'SecurePassword', 'Certificate', 'Path', 'Store', 'Folder', 'Flag', 'EnableException'
$knownParameters += [System.Management.Automation.PSCmdlet]::CommonParameters
It "Should only contain our specific parameters" {
(@(Compare-Object -ReferenceObject ($knownParameters | Where-Object {$_}) -DifferenceObject $params).Count ) | Should Be 0
Describe "Add-DbaComputerCertificate" -Tag "UnitTests" {
Context "Parameter validation" {
BeforeAll {
$command = Get-Command Add-DbaComputerCertificate
$expectedParameters = $TestConfig.CommonParameters

$expectedParameters += @(
"ComputerName",
"Credential",
"SecurePassword",
"Certificate",
"Path",
"Store",
"Folder",
"Flag",
"EnableException"
)
}

It "Should have exactly the expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
}

It "Has parameter: <_>" -ForEach $expectedParameters {
$command | Should -HaveParameter $PSItem
}
}
}

Describe "$commandname Integration Tests" -Tags "IntegrationTests" {
Describe "Add-DbaComputerCertificate" -Tag "IntegrationTests" {
Context "Certificate is added properly" {
$results = Add-DbaComputerCertificate -Path "$($TestConfig.appveyorlabrepo)\certificates\localhost.crt" -Confirm:$false
BeforeAll {
$results = Add-DbaComputerCertificate -Path "$($TestConfig.appveyorlabrepo)\certificates\localhost.crt" -Confirm:$false
}

It "Should show the proper thumbprint has been added" {
$results.Thumbprint | Should Be "29C469578D6C6211076A09CEE5C5797EEA0C2713"
$results.Thumbprint | Should -Be "29C469578D6C6211076A09CEE5C5797EEA0C2713"
}

It "Should be in LocalMachine\My Cert Store" {
$results.PSParentPath | Should Be "Microsoft.PowerShell.Security\Certificate::LocalMachine\My"
$results.PSParentPath | Should -Be "Microsoft.PowerShell.Security\Certificate::LocalMachine\My"
}

Remove-DbaComputerCertificate -Thumbprint 29C469578D6C6211076A09CEE5C5797EEA0C2713 -Confirm:$false
AfterAll {
Remove-DbaComputerCertificate -Thumbprint 29C469578D6C6211076A09CEE5C5797EEA0C2713 -Confirm:$false
}
}
}

0 comments on commit 9eadcd1

Please sign in to comment.