publish to v0.0.1-alpha #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicogelders
reviewed
Oct 12, 2023
setup.py
Outdated
| @@ -0,0 +1,24 @@ | |||
| from distutils.core import setup | |||
There was a problem hiding this comment.
why do we need setup.py/cfg? Isn't everything in the pyproject.toml?
nicogelders
reviewed
Oct 13, 2023
GETTING_STARTED.md
Outdated
| * **flow_kwargs**: A dictionary of Prefect flow arguments. | ||
| Here's a basic example of how to use dbt_flow(): | ||
| ```python | ||
| my_flow = dbtFlow.dbt_flow( |
There was a problem hiding this comment.
this code is not correct
nicogelders
reviewed
Oct 13, 2023
GETTING_STARTED.md
Outdated
| from prefect_dbt_flow import dbt_flow | ||
| ``` | ||
| 2. **Define the Prefect Flow:** | ||
| Create a Prefect flow by initializing a `dbtFlow.dbt_flow` object. You can configure it with your dbt project, profile, and additional options: |
nicogelders
reviewed
Oct 13, 2023
|
|
||
| run the following comand to seed the csv files: | ||
| ```bash | ||
| dbt seed |
There was a problem hiding this comment.
after we implement the seed command we need to remember to change this.
nicogelders
reviewed
Oct 13, 2023
README.md
Outdated
|
|
||
| ## Inspiration | ||
| Prefect-dbt-flow draws inspiration from various projects in the data engineering and workflow orchestration space, including: | ||
| - cosmos by astronomer |
There was a problem hiding this comment.
nicogelders
reviewed
Oct 13, 2023
README.md
Outdated
| <a href="https://pepy.tech/project/prefect-dbt-flow"><img alt="Downloads" src="https://pepy.tech/badge/prefect-dbt-flow" /></a> | ||
| <a href="https://github.com/psf/black"><img alt="Code style: black" src="https://img.shields.io/badge/code%20style-black-000000.svg" /></a> | ||
| <a href="http://mypy-lang.org/"><img alt="Mypy checked" src="https://img.shields.io/badge/mypy-checked-1f5082.svg" /></a> | ||
| <!-- <a href="https://pepy.tech/project/prefect-dbt-flow"><img alt="Codecov" src="https://codecov.io/github/datarootsio/databooks/main/graph/badge.svg" /></a> |
nicogelders
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.