Make it so that headings are shown in full when you click on a link to them #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought I already fixed this with a commit to Aurora. Does Aurora need a restart for that to apply or did it not work? |
I think it did not work. From my (very limited) testing it only works if you very explicitly apply it to the |
Or perhaps it is not deployed properly, that rule does not appear to be present in https://aurora.datasektionen.se/ Do note that aurora doesn't have any autodeploy stuff |
|
@foodelevator redeployed and it worked! Do we close this PR? |
|
Yup! |
|
Fixed by datasektionen/Aurora@f87648a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, you would be scrolled to just below a title when clicking on it, now you will instead see the whole heading (example). I've been annoyed by this for way too long :p
I practice I don't think we have any headers deeper than
h3, but we support them in theory, so why not future-proof all the way toh6.Apparently this css rule does not work on the default iPhone browser according to some link online? But i don't have an iphone so I can't test, and the index sidebar is basically useless on phone anyway.