Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic search #40

Merged
merged 9 commits into from
Feb 21, 2023
Merged

Add basic search #40

merged 9 commits into from
Feb 21, 2023

Conversation

adriansalamon
Copy link
Member

Added basic search (only for users now), can be easily expanded with this as reference. See #39 for more possibilities.

Changes

  • Added searchbar for mobile and desktop to search for full user names
  • Fixed sidebar flicker issue

References

I used this as reference for SQL search with Ecto: https://www.peterullrich.com/efficient-name-search-with-postgres-and-ecto, and https://www.peterullrich.com/complete-guide-to-full-text-search-with-postgres-and-ecto

@adriansalamon adriansalamon marked this pull request as ready for review February 20, 2023 09:51
@adriansalamon adriansalamon added the enhancement New feature or request label Feb 20, 2023
Copy link
Contributor

@MartinRybergLaude MartinRybergLaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🙌😁

@adriansalamon adriansalamon merged commit 5aea09f into dev Feb 21, 2023
@adriansalamon adriansalamon deleted the feat/add-search branch February 21, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants