appspec.yaml for CodeDeploy agent #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user has not first AND last name the function PersonsName->getLastFirst() returned still a ", " seperator
The function PersonsName->getMiddleInitial() adds the "." only if necessary. Now it can used internal easier.
The functions PersonsName->getShort() and getShortFormal() had also problems with users that don't have first AND last name
If the total value for the class PageNate is a *valid* string number the class still used a fixed 500 value
This addresses an issue where when using the variable `ticket.dept.sla` the
system throws a fatal error. This is due to the SLA's relation to Department
defined in `include/class.dept.php`. It's defined as `array('sla_id' =>
'SLA.sla_id')` which is incorrect as `SLA.sla_id` does not exist. This
updates the relation from `array('sla_id' => 'SLA.sla_id')` to
`array('sla_id' => 'SLA.id')` so that it uses the appropriate column.
This commit fixes an issue we had with list items that began or ended with a space. If the list was being used in a Typeahead or Input field, the values couldn't be selected if they didn't match with the spaces exactly. This commit strips the leading and trailing spaces before saving the list items.
Add dynamic file upload field attachments to zip file export.
This commits makes max-age (ttl) for logos and backgrounds consistent regardless of the storage backend.
If a agent has no permissions and you will give him/her the first permission, the class Staff->updatePerms() wrote a `array_key_exists() expects parameter 2 to be array, null given` warning. Problem is, that $permissions->perms is null. With a RolePermission->exists() function is the code easier to read an don't show the warning.
This commits improves on f9626f8 by defaulting to empty array instead of suppressing warning on param 2 being null.
Localize status names by default
This addresses a small issue where the links to the Release Notes were pointing the old location in the Docs. This updates the links to point to the Github Releases page where it shows all Release Notes for all versions.
In the ticket overview for the users get the 'Open' heading not translated.
This commit fixes an issue with exporting Custom Department or Custom Assignee fields. In the exports, the fields were exporting as IDs instead of the actual field value. Custom Department Field: In from_query, if the value is just a dept_id instead of the department name, the field should pass the display function. Custom Assignee Field: - In to_php, we were missing logic needed to parse cdata into an array if the value was saved as 'id,value' Ex: t34,Team1 First, we need to make sure not to accidentally clear out this value if the JsonDataParser doesn't work. Next, this string needs to be set to an array like this in order to render properly: ['t34'] => 'Team1' - If there is an Assigntee type, we should use substr to remove the letter from the array key in the event that the id for the field is more than one number Ex: t34 The type should be 't' and the id should be 34. Using key($value)[1] would set the id to just 3 - If the value coming into AssigneeField::to_php is the staff_id, meaning the value is just a number and we are not sending a type through, we should look up and return the Staff object.
This commit adds functionality that will allow us to use the attrs field in the file table to determine the file location being used for the S3 Pluign. Credit goes to @protich
This addresses a very minor issue where the draft save on EmailTest throws an error. This is due to changes made in 5694 where `message` was removed from `$field_list` (security reasons). This updates the name of the textarea from `message` to `body`. This allows the `_findDraftBody()` method to find the body successfully and continue on. This also updates every reference of `message` to `body` in this instance.
This upgrades Redactor from 3.4.9 to 3.4.11 so that we are utilizing the latest code. This provides a few bug fixes and improvements.
This addresses an issue where editing your own Thread Entry and clicking Save two separate times drops the attachment(s). This is due to the order of operations in the backend where if editing your own Thread Entry we delete the previous entry and set `$old` to the original Thread Entry (parent of the previous entry). This causes the attachment lookup to search for the wrong `object_id` which obviously finds no attachments. This moves the attachment lookup before we delete the previous entry so we can search with the appropriate ID.
…sion-3.4.11 redactor: Upgrade to version 3.4.11
…-folders Enhancement: S3 Plugin Folder Capability
…alert-email-template Reviewed By: Peter Rotich <[email protected]>
Reviewed-By: Peter Rotich <[email protected]>
Reviewed-By: Peter Rotich <[email protected]>
…rting-by-updated Reviewed-By: Peter Rotich <[email protected]>
…ar-sla_id Reviewed-By: Peter Rotich <[email protected]>
Reviewed-By: Peter Rotich <[email protected]>
Reviewed-By: Peter Rotich <[email protected]>
Reviewed-By: Peter Rotich <[email protected]>
This commit addresses an issue introduced by commit b755b99.
This addresses an issue where attempting to Assign a Child Ticket throws a fatal error of `Call to a member function getReferral() on null`. This is due to the `thread` relation not being available for Child Tickets; instead `child_thread` is available. This updates the code to use `getThread()` which first checks if `thread` relation exists, if not it returns the `child_thread` relation.
…-referral-check Reviewed-By: Peter Rotich <[email protected]>
Auth: Service Name on Client Portal
This upgrades Redactor from 3.4.12 to 3.5.0 so that we are utilizing the latest code. This provides a few bug fixes and improvements.
…sion-3.5.0 redactor: Upgrade to version 3.5.0
This adds an extra layer of security to Sessions where we will verify the UserAgent string. We will check to see if the UserAgent string saved in the database matches the current UserAgent string from the request. If the two do not match we will destroy the session and force the affected User/Agent to login again.
This mitigates a vulnerability reported by @tieupham267 where XSS is possible via the `REQUEST_URI` parameter on the Client Portal. This is due to the parameter not being converted to HTML entities before attaching to `<link>` tags. This adds `htmlspecialchars()` around the `REQUEST_URI` to ensure the content is properly converted.
This addresses a security vulnerability reported by xxx where uploading a malicious SVG, getting the direct file link, adding `s=1` to the end, and visiting the link directly will render the SVG in the browser and execute the malicious Javascript within the SVG. This adds a CSP (Content Security Policy) header with `default-src 'self'` to the display code. When this header is present it prevents all inline Javascript execution thus mitigating the XSS.
This upgrades Redactor from 3.5.0 to 3.5.1 so that we are utilizing the latest code. This provides a few bug fixes and improvements.
This addresses an issue where when `OsticketConfig::getDBVersion()` is ran, a `column not found` SQL Error is generated. This is due to the config table structure being completely different from 1.7 onwards. This adds a check to see if the `MAJOR_VERSION` constant is defined, if so, it will skip the `OsticketConfig::getDBVersion()` call in `include/class.ostsession.php` (thus skipping the query execution). If the constant is not defined it will continue on and call `OsticketConfig::getDBVersion()`.
This addresses 5930 where the Helptip for the Admin Password field on Install is incorrect. The Helptip states the password has to be a minimum of 5 characters where in reality it requires a minimum of 6. This updates the Helptip as well as the inline string from `Must be five (5) characters or more.` to `Must be six (6) characters or more.`. In addition, this updates the phrase `(Five characters min)` to `(Six characters min)` in `include/class.validator.php` as well as updates the check for less than 5 characters.
…sion-3.5.1 redactor: Upgrade to version 3.5.1
…errors Reviewed-By: Peter Rotich <[email protected]>
…ord-heltip-verbiage Reviewed-By: Peter Rotich <[email protected]>
Reviewed-By: JediKev <[email protected]>, Aydreeihn <[email protected]>
This addresses an issue reported by Vladislav Alyohin where Users can create a Ticket in the Client Portal and click Refresh over and over again on success. The result is a duplicate Ticket being created (with a different Ticket Number) for each refresh. This adds an else statement so if there is no client or if they are no longer valid we will rotate the CSRF token. This will create the initial Ticket and on refresh will force the User back to the Landing Page.
Reviewed-By: JediKev <[email protected]>, Aydreeihn <[email protected]>
Reviewed-By: JediKev <[email protected]>, Aydreeihn <[email protected]>
…t-string Reviewed-By: JediKev <[email protected]>, Aydreeihn <[email protected]>
Reviewed-By: JediKev <[email protected]>, Aydreeihn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.