-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resources templating option to kaap operator deployment #159
base: main
Are you sure you want to change the base?
Conversation
Any update on this one? |
Thanks @MarkusNeuron |
@MarkusNeuron can you please fix the CI? I think you have to add the new values property here:
|
Add new template variable operator.resources to test
Added var to test. Hope this fixes CI. |
Test failed again. It seems that the test library can not work with templating functions. I will change test test to an empty resources key. I hope to fix the testcase issue this way. |
Remove requests and changed to empty resource key
Sorry guys I do not know how to fix this in test. When I template with: operator:
enabled: true
image: datastax/kaap:0.2.0
imagePullPolicy: IfNotPresent
replicas: 1
resources: {}
livenessProbe:
failureThreshold: 3
... of without resource key at all I get the correct output without resource config. Templating with values: operator:
enabled: true
image: datastax/kaap:0.2.0
imagePullPolicy: IfNotPresent
replicas: 1
resources:
requests:
cpu: "0.2"
memory: "512Mi"
limits:
memory: "512Mi"
livenessProbe:
failureThreshold: 3 leads also to the correct template: ...
spec:
containers:
- env:
- name: KUBERNETES_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
envFrom:
- configMapRef:
name: kaap
image: datastax/kaap:0.2.0
imagePullPolicy: IfNotPresent
resources:
limits:
memory: 512Mi
requests:
cpu: "0.2"
memory: 512Mi
livenessProbe:
failureThreshold: 3
... So how we can fix the java for ci testing? |
For our cluster operation and complying to security standards its mandatory being able to configure pod resources.
Some standards for resources configuration we need to comply:
Because we should be flexible to applying different patterns for resource-requests and -limits I templated the full
resources:
block depending on values configuration and not the individual values.E.g. one example pattern for requests and limits