function uploadBuiltinSinksSources #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1038
to
+1039
| # upload false means the connector jar will not uploaded from bookie but from the same version as function worker | ||
| uploadBuiltinSinksSources: "false" |
There was a problem hiding this comment.
I think we should remove this configuration option and set it to false always. Unless I'm misunderstanding something, I don't see any reason for a user to set this as true when running in k8s. Do you agree @zzzming or do you think we should make this configurable?
pgier
pushed a commit
to pgier/datastax-pulsar-helm-chart
that referenced
this pull request
Jul 13, 2022
Fixes datastax#147 ### Motivation This gives the helm chart user the ability to specify a secret or other type of volume to be mounted into any of the statefulset pods ### Modifications * Added conditionals to `bookkeeper`, `broker`, `proxy`, `toolset`, and `zookeeper` statefulsets which allow the chart user to specify extraVolumes and extraVolumeMounts for deployed pods. * Added `extraVolumes` and `extraVolumeMounts` parameters to values.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A configuration allows the connector jar to be updated to the same version as the function worker jar when the connector is restarted. This happens when uploadBuiltinSinksSources = false
When it's set true, the jar will be uploaded from the bookie. This means upgrading the function worker, the connector jar won't be upgraded with restarting