Set the advertisedAddress to pod IP when TLS isn't enabled

[lhotari]

• DNS resolution causes an extra hop for Pulsar topic lookups
• DNS resolution fails with current settings until the broker's readiness probe succeeds. Pulsar might already return the hostname of a specific broker to a client, but the client cannot resolve the DNS name since the broker's readiness probe hasn't passed. This causes some extra delays when connecting to topics after a load balancing event.
• broker-deployment already uses a similar solution so it would be consistent to do this also in broker-sts.

  • pulsar-helm-chart/helm-chart-sources/pulsar/templates/broker-deployment/broker-deployment.yaml

    Lines 286 to 289 in d968aba

    	- name: advertisedAddress
    	valueFrom:
    	fieldRef:
    	fieldPath: status.podIP

[michaeljmarshall]

I don't think we should merge this feature because it would break namespace affinity rules, which rely on stable broker advertised addresses.

[lhotari]

I don't think we should merge this feature because it would break namespace affinity rules, which rely on stable broker advertised addresses.

@michaeljmarshall I guess you mean "namespace isolation policy"? (pulsar-admin ns-isolation-policy) ?

Perhaps it should be configurable whether IP addresses or DNS names are used. It's very rare to use the "namespace isolation policy" feature.

[michaeljmarshall]

@lhotari - yes, that is the feature I meant to reference, and I think you're right that it's a rarely used feature. The real problem is that this solution does not work when TLS hostname verification is enabled. I think the primary reason to use a STS is when deploying with TLS. If that isn't a requirement, I think I'd recommend deploying with a Deployment